Skip to content

Make utility_meter tariffs a list#68967

Merged
MartinHjelmare merged 1 commit intodevfrom
utility_meter_tariffs_list
Mar 31, 2022
Merged

Make utility_meter tariffs a list#68967
MartinHjelmare merged 1 commit intodevfrom
utility_meter_tariffs_list

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Make utility_meter tariffs a list in the config flow

Depends on #68952

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery marked this pull request as draft March 31, 2022 08:55
@emontnemery emontnemery marked this pull request as ready for review March 31, 2022 09:29
@emontnemery emontnemery reopened this Mar 31, 2022
@MartinHjelmare MartinHjelmare force-pushed the utility_meter_tariffs_list branch from ad8ca42 to dba66f9 Compare March 31, 2022 11:52
@MartinHjelmare
Copy link
Copy Markdown
Member

Rebased on latest dev.

@MartinHjelmare MartinHjelmare merged commit 400943c into dev Mar 31, 2022
@MartinHjelmare MartinHjelmare deleted the utility_meter_tariffs_list branch March 31, 2022 11:57
balloob pushed a commit that referenced this pull request Mar 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants